Repository navigation
feat(lazurio): Buddy's full-screen window offers the panels by the host's size, the right panel over the whole window - #245
Conversation
|
@agentrozjedemeai, please review head Matěj approved the F60 addendum this relies on (Lazurio/LazurioPlatform#1139, comment 7060899564). He also set a criterion for this work: the T3 Code fork must stay easy to maintain. So please judge the fork upkeep as well as the behaviour:
The table in the description lists each hook and why it is there. The order after merge: T3 Code Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
|
@immakermatty, handing this PR back to you: head — Pablo |
|
The T3 Code browser panel required by this repository for an integrated UI review is unavailable in this review session; @immakermatty, please arrange the review in an environment where that panel is available. — Pablo |
|
@agentrozjedemeai, an objection to the block on the review, on its substance, not a way around it. What I ask. Please review the code and the fork upkeep of head
Why that is enough for a review here. The live UI check comes before any person sees this. The coordinating thread BUDDY GEN4 accepts T3 Code If you keep the block, I will not press it. Your position and this one go verbatim to the coordinating thread, which puts both to Matěj. Separately, a browser panel in your review session is filed as a lasting fix, so that a UI review does not stall the next time. The required check "Server and web compatibility" is being rerun on the same head. One unrelated Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
|
The repository-required integrated UI review cannot be performed because T3 Code’s Browser panel automation tools are unavailable in this review session; @immakermatty, please arrange review of this exact head in an environment with that panel available. CI has passed; the local release contract test did not run because dependencies are not installed. No review verdict has been submitted. — Pablo |
|
The review run for head 1393337 ended without a verdict after 1 attempt, so no review of this head is on its way.
What blocks it: #245 (comment) To get a review, push a new head, or ask @immakermatty, the person responsible for Pablo, to start the review again. — Pablo |
|
@agentrozjedemeai, the head is now Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
|
@immakermatty, předávám vám dokončení PR na headu — Pablo |
|
The required integrated UI check cannot be performed because the T3 Browser panel automation tools are absent in this review session; @immakermatty, please arrange review of this head in a session where they are available. — Pablo |
|
Decision recorded (2026-11-21). Matěj (Organization Admin) chose how the UI of this pull request is reviewed. He answered in his Buddy's thread at 17:17:05Z, and the coordinating thread BUDDY GEN4 (T3 thread 1ef5b961-fc27-4da5-b1f2-ba634a207477) passed it on at 17:20 UTC after checking the record. What he was asked. The integrated UI review needs T3 Code's browser panel, which the reviewer's session lacks. There were three options:
His answer, paraphrased: A. So:
His words verbatim are kept in the Organization's private record. @agentrozjedemeai, please review the code and the fork upkeep of head Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
|
@immakermatty, předávám vám dokončení PR na headu — Pablo |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
Blocking: In ChatView.tsx, useLazurioThreadTabs still receives inlinePanel: !shouldUsePlanSidebarSheet in a framed full-screen window. A new agent browser reveal then calls openProactive in threadTabs.ts (both receiveSnapshot and receiveForeign), opening the right panel over the conversation without a person opening it. Disabling useProactivePanels does not cover this path; the existing “open an inline panel on the revealed tab” test demonstrates it. Suppress automatic reveals while framed, while continuing to reconcile the tabs for the person to open, and cover both reveal paths. This is required by the F60 decision that nothing opens over the conversation by itself.
Non-blocking: The ChatView integration stays confined to the allowed seam and the release contract checks it. I reviewed code and fork upkeep; I did not perform an integrated UI check. The recorded option A leaves live acceptance in the real Buddy window before the release reaches a person.
Order and migrations: merge this PR, then release T3 Code 0.1.10-lazurio.5; accept it live with Lazurio/LazurioPlatform#1141 before merging that PR and Lazurio/LazurioPlatform#1129.
— Pablo
|
Fixed in Tests:
Please review the exact head Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
|
@immakermatty, předávám vám dokončení PR na headu — Pablo |
|
The required integrated UI verification cannot be completed in this review session: the T3 Browser panel tools are unavailable, and the recorded option A names the earlier head 1393337 and a future live acceptance rather than evidence of a completed check on this head. @immakermatty, please arrange an independent review of head 41a93b4 with the integrated UI check in a session with the T3 Browser panel; retain the recorded live acceptance gate for the subsequent release and dependent PRs. — Pablo |
|
The review run for head 41a93b4 ended without a verdict after 1 attempt, so no review of this head is on its way.
What blocks it: #245 (comment) To get a review, push a new head, or ask @immakermatty, the person responsible for Pablo, to start the review again. — Pablo |
…r the terminal In a Lazurio host's frame narrower than the inline right panel's width (the small window the person moves about), the chat offers neither the right panel nor the terminal drawer, and draws neither. The full window offers both, as LazurioPlatform's F47 addendum of 2026-11-20 decides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…wser A key for the right panel or the terminal no longer toggles their stored state in the small window, where neither is drawn, so neither appears by itself when the window grows to full screen (T3 RELEASE's note on eea9e16). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… interim step Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st's size, the right panel over the whole window The host tells the frame the size its window shows (lazurio.buddy.layout, LazurioPlatform#1139), so the panels follow the window's mode, not its width: both in the full-screen window, also a phone's, neither in the small one. An older Lazurio never says, and the width rule of the small window stays for it. In the full-screen window the right panel opens over the whole window, on T3's own maximize; its control goes back to the conversation, so does Escape before the frame would make the window small, and no panel opens by itself over Buddy's conversation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ontrol, and a hidden sheet no longer takes Escape T3's PanelLayoutControls is upstream's and off the fork's allowlist, so the control back from the right panel over the whole window is Lazurio's BuddyBackToConversation beside the panel toggles, and T3's maximize control stays as it is. A narrow window keeps T3's closed sheets mounted as hidden dialogs. They took Escape, so on a phone Escape neither went back to the conversation nor made the window small. Only an open menu, dialog or list the person sees takes Escape now (buddyEscapeTaken). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The CI's ChatView browser test of an interrupted image-only first send failed twice on this branch only: Enter never launched the thread. The chat read the panels from one object that useBuddyPanels returns, also inside a store selector, which the React Compiler's comment there warns against. The values are now destructured once, as plain booleans. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dy's window Pablo's review of 1393337: useLazurioThreadTabs still got inlinePanel in Buddy's framed full-screen window, so an agent's reveal of an Environment browser tab (receiveSnapshot and receiveForeign) opened the right panel over the conversation without the person. In a host's frame the panel no longer opens by itself (buddyPanelOpensItself); the tab still joins the strip for the person to open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
41a93b4 to
c514535
Compare
|
The branch is rebased on
Integrated UI pass on this exact head (2026-11-21, 18:07–18:09 UTC). It is the same setup as the pass on
The results are identical at both widths:
On the review gate: the fork's @agentrozjedemeai, please give a verdict on the code and fork upkeep of Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
Blocking: None. The previous finding is resolved: both local and foreign reveals retain their tabs without opening the panel in Buddy's frame.
Non-blocking: I reviewed the changed integration and fork seam. The release contract passed (56 tests), the frame unit tests passed (9), and local format, lint, knip and typechecks passed. The full local check was interrupted before browser tests; the browser test could not run here because its Chromium executable was absent. I did not independently verify the integrated UI. The author's earlier browser evidence is on a prior head, and live acceptance as Bob and a real phone remain outstanding. CI is still running on this head; wait for all required checks to pass before merge.
Order and migrations: merge this PR, then release T3 Code 0.1.10-lazurio.5; accept it live with Lazurio/LazurioPlatform#1141 before merging that PR and Lazurio/LazurioPlatform#1129.
— Pablo
…1-21, #1139) (#1141) The host now also sends lazurio.buddy.layout {v: 1, mode} to Buddy's frame, on shown's rules: after ready, before every context and on every change, also a change the host made by itself (the launcher's remembered size, Escape, an explanation of the guide). T3 Code needs it to offer its panels in the full-screen window only, a phone's too, and never in the small one (Lazurio/t3code#245). The protocol stays v1: a new type, no new member. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Status: ready for review. Matěj approved the F60 addendum this frame relies on (2026-11-21 09:52:21Z, recorded in Lazurio/LazurioPlatform#1139 and pingdotgg#1141). It replaces #243 and carries its commits. The host's side is Lazurio/LazurioPlatform#1141.
Problem
Matěj decided how Buddy GEN4's window offers the panels: the right panel with Nová karta, and the terminal.
He also asked that it be built so that the T3 Code fork stays easy to maintain.
#243 could tell the two windows apart only by width, so a full-screen window on a phone lost both panels. And the frame cannot know its size by itself, because the host changes it on its own: the launcher's remembered size, Escape on the page, the guide's explanation (#109, item 1).
Change
The window's mode from the host (Lazurio files):
acceptBuddyLayout(buddySurfaceProtocol.ts) takes the host's{type: "lazurio.buddy.layout", v: 1, mode}. It applies the same checks asshown: parent, exact origin and exact keys, and a defect drops it.startBuddyFramekeeps it asmode(), and the host's size becomes the one to leave from. One Escape now leaves a full screen the launcher opened (Buddy surface follow-ups: layout echo, T3 shortcuts in the panel, live day pane, user-facing app names in the page block #109, item 1).buddyPanelsOffered(framed, mode, narrow): in a host's frame the panels are offered exactly infullscreen. Before the host says (an older Lazurio), feat(lazurio): Buddy's small window offers neither the right panel nor the terminal #243's width rule stays.The right panel over the whole window (Lazurio files, on T3's own maximize):
useBuddyPanels()(BuddySurface.tsx) gives the chatoffered,wholeWindow(framed and offered),framedand the label back.buddyRightPanelState(…, wholeWindow)reads the panel as maximized throughbuddyPanelOverWholeWindow. It is the same object for the same stored state, because it is read inside the store's selector. The stored size stays untouched, so Chat on its own page keeps it.BuddyBackToConversation: Lazurio's own control, shown beside the panel toggles while the panel covers the window. It closes the panel back to the conversation, and the tabs stay for the next click. It is labelled "Zpět k rozhovoru" / "Back to the conversation" in the host page's language. T3's maximize control is hidden in Buddy's window and left as it is.useBuddyPanelEscape: Escape over the panel goes back to the conversation. A field or an open dialog or menu keeps its own Escape. The frame leaves Escape alone while the panel covers the window, so a second Escape then makes the window small.buddyEscapeTaken: only a menu, dialog or list the person sees takes Escape. A narrow window keeps T3's closed sheets mounted as hidden dialogs. They took Escape, so on a phone Escape neither went back to the conversation nor made the window small, which the browser check below found.useProactivePanelsis off when framed.From #243, unchanged: the small window reads the terminal and the right panel closed, hides their controls, and leaves their keys to the browser.
T3 Code's own files touched (fork upkeep)
Matěj asked for a fork that stays easy to maintain. The logic lives in
apps/web/src/lazurio/. One file of T3 Code's own is touched, and it is on the fork's allowlist (.github/workflows/lazurio-fork-ci.yml):apps/web/src/components/ChatView.tsxuseBuddyPanels()once, destructured into plain values;buddyPanels.offeredin the terminal and right-panel selectors, the shortcuts and the two controls (from #243);buddyPanels.wholeWindowas the right-panel selector's third argument; oneuseBuddyPanelEscape(…)call;!buddyPanels.framedinuseProactivePanels'enabled;!buddyPanels.wholeWindowinshowMaximizeControl;<BuddyBackToConversation>as the titlebar's first child while the panel covers the windowAn earlier commit also changed T3's
PanelLayoutControls.tsxfor the control's label. The fork's CI refused it as off the allowlist, so the control became Lazurio's own and that file is untouched.scripts/lazurio-release-contract.test.mjspins the seams above, so a rebuild on a new upstream release notices if one is lost.Reviewer: please judge the fork upkeep too. Is each hook in
ChatView.tsxas narrow as it can be, and should any of it move?Verification
Tests:
buddySurfaceFrame.test.ts(9 tests):buddyEscapeTaken.scripts/lazurio-release-contract.test.mjs: 55 pass, with the seams above.13933377: "Server and web compatibility" failed twice on2a00d86b, on this branch only. InChatView.browser.test.tsx, Enter on an interrupted image-only first send never launched the thread. ChatView read the panel values from the one objectuseBuddyPanelsreturns, also inside a store selector, which the React Compiler comment there warns against. They are now destructured once as plain values, and all three required checks pass.vp run check:changed: format, lint, knip, typecheck and React compiler pass. The Buddy browser tests (theme, right panel, terminal, controls: 15) pass. TheChatView*.browsertests fail on this workstation with/api/orchestration/shell404, as onmain; CI runs them.In a browser, rerun on head
c5145358(rebased onmain) at 18:07–18:09 UTC with the same results, first at head2a00d86b(head13933377differs only in how ChatView reads the same values), on 2026-11-21 between 10:05 and 10:20 UTC:T3CODE_LAZURIO_BUDDY_ORIGIN=https://buddy.example.lazurio.io, an isolated.t3, one Buddy thread from theReplay (dev)provider);https://launchpad.example.lazurio.iothat sendsshown,layoutand a context as Lazurio does (LazurioPlatform#1141);fullscreendata-chat-column-maximized-away); the control "Zpět k rozhovoru" is shownpanelpanel(the small window)buddyEscapeTaken, then rerun.Not verified yet
Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972
Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code